Implement Undo/Redo operations batching #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⏭️ No files to mutate for |
|
⏭️ No files to mutate for |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 100% | 0/0 |
| 🟢 | Branches | 100% | 0/0 |
| 🟢 | Functions | 100% | 0/0 |
| 🟢 | Lines | 100% | 0/0 |
Test suite run success
1 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from 8cf8828
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 96.05% | 802/835 |
| 🟢 | Branches | 96% | 216/225 |
| 🟢 | Functions | 87.39% | 194/222 |
| 🟢 | Lines | 95.91% | 773/806 |
Test suite run success
405 tests passing in 24 suites.
Report generated by 🧪jest coverage report action from 8cf8828
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 97.97% (-0.03% 🔻) |
145/148 |
| 🟢 | Branches | 91.67% (-3.33% 🔻) |
55/60 |
| 🟢 | Functions | 94.74% (-5.26% 🔻) |
18/19 |
| 🟢 | Lines | 97.95% (-0.05% 🔻) |
143/146 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | OperationsBatch.ts | 100% | 93.75% | 85.71% | 100% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟢 | CollaborationManager.ts | 94.55% (-0.8% 🔻) |
78.95% (-7.72% 🔻) |
100% | 94.55% (-0.8% 🔻) |
Test suite run success
66 tests passing in 4 suites.
Report generated by 🧪jest coverage report action from 8cf8828
neSpecc
reviewed
Apr 8, 2025
| * | ||
| * Operations are batched on timeout basis or if batch is terminated from the outside | ||
| */ | ||
| export class Batch { |
Contributor
There was a problem hiding this comment.
maybe call it BatchedOperation?
neSpecc
approved these changes
Apr 8, 2025
| this.#undoRedoManager.put(effectiveOp); | ||
| } | ||
|
|
||
| this.#currentBatch = lastOp === undefined ? null : new Batch(onBatchTimeout, lastOp); |
e11sy
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.